Fix exception on resource middle click in NEIE #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #137, I guess |
DaleStan
previously approved these changes
Jun 4, 2024
shpaass
reviewed
Jun 4, 2024
shpaass
reviewed
Jun 4, 2024
exyi
force-pushed
the
fix-NEI-midbtn-crash
branch
2 times, most recently
from
b73020f to
3346222
Compare
|
@DaleStan Thanks, I added the changelog.txt entry |
veger
previously approved these changes
Jun 4, 2024
In the Never Enough Items, middle click on a resource. This will navigate to the clicked resource, but also crashed the current Build process, because of modification of the iterated list.
exyi
force-pushed
the
fix-NEI-midbtn-crash
branch
from
3346222 to
79f18d0
Compare
shpaass
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Never Enough Items, middle click on a resource. This will navigate to the clicked resource, but also crashed the current Build process, because of modification of the iterated list.
Middle click on this:
... and error shows up:
Note that the middle click still works, it just an annoyance.
Solution is clone the List when replacing it's contents. Since its listy features are no longer required, I switched it to use an array instead.