Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display spent fuel #141

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Display spent fuel #141

merged 3 commits into from
Jun 3, 2024

Conversation

DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Jun 2, 2024

This updates the recipe row and link summary displays to deal with spent fuel, as shown below. The change in ash output for the Void Ash recipe is because ash is both a recipe output and a spent fuel output; the solver already did the right thing.

Untitled

veger
veger previously approved these changes Jun 2, 2024
Copy link
Collaborator

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It will definitely be convenient to see the actual spend fuel instead of having it 'magically' appear in the extra products.

The code change looks fine to me, I didn't try it out though. You only forgot to add a line to the changelog about this change.

@shpaass
Copy link
Owner

shpaass commented Jun 2, 2024

On the linked gif, is it expected that the ash number changed at bottom-right?

@DaleStan
Copy link
Collaborator Author

DaleStan commented Jun 3, 2024

Yes, the change to ash output is intentional; the extra 0.56 is the spent fuel output that wasn't displayed before. An earlier version had two ash outputs, but I decided I didn't like that:
image

@shpaass shpaass merged commit 9df2f7f into shpaass:master Jun 3, 2024
1 check passed
@DaleStan DaleStan deleted the display-spent-fuel branch June 9, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants