Page search for specific things on the page #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to desired and extra products, allow searching by ingredients and recipe.
Always set the input focus to the end of the text, since that's where you want to type.
veger
previously approved these changes
May 17, 2024
There was a problem hiding this comment.
Code looks good and it looks nice/seems to work
I have two remarks though
- Please add an entry for the changelog
- Can we have this search even when no pages are closed? (Separate PR? 🤔) As it is (also) convenient to search for certain products/recipes/etc when having lots of pages!
shpaass
reviewed
May 17, 2024
…always returns zero results.
shpaass
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #65 by allowing you select where on a page you want to search, though I may have gone overboard:
In addition to what's obvious from the screenshot: The default setting is to only search in page names,
you always have to have at least one box checked, the radio buttons are disabled if you're only searching in the page names, unchecking the "All" box will restore the checkbox state that was present when you checked it, and the input focus is now set to the search box when you open the dropdown. Most of these are in their own commits, if one or more should be removed.