Implement a version of ShadowTheAge#181, allowing XXb to specify XX belts of production.

[DaleStan]

Also look for /s, /m, or /h suffixes. If present, use that suffix regardless of the current display settings.

The objectives I developed over the course of implementing this, re-implementing it, and remembering I needed to write tests, were:

• Allow specifying a certain number of belts of production or consumption, by typing "XXb"
• Correctly parse /s, /m, and /h suffixes, regardless of the current display preferences.
• Preserve existing behavior with regards to case sensitivity and bare-number input:
  • Preserve mW == MW for now
  • "100" still means 100 of whatever unit is normally displayed in that box.
• Be as permissive as reasonable about whitespace. (More permissive than I intended, to allow parsing the "10 000" output from calling FormatValue(..., precise: true))
• Correctly parse any string YAFC can display:
  • Allow p and /t suffixes when they have meanings in the preferences. (That said, /t always has a meaning.)
  • Fix the bug that "10W" is parsed as ten megawatts instead of ten watts.
• Prevent use of non-applicable units or garbage input:
  • No reporting you built "5/m" buildings or "30%" beacons, and no sticking a "?" anywhere in your input.
  • On the other hand, do allow "+15e+4", which is valid formatting for a float.

I'm not opposed to repurposing m for milli- instead of mega-, but I didn't want to do that here.

[shpaass]

remembering I needed to write tests

Tests would be very welcome, especially as this function can be tested without a set-up because it's public static.

Edit: alright, now I see them. Apologies :D

[shpaass]

SIck tests! The most thorough I've seen so far.

[shpaass]

I approved, but someone else needs to take a look at it too, just to be sure.

[veger]

Nice to see you are back at YAFC/Factorio 😄

I'm not opposed to repurposing m for milli- instead of mega-, but I didn't want to do that here.

Same, having the correct letters for the correct 'factors' is less confusing (and players might even learn a thing or two 😉 )

[shpaass]

@veger

having the correct letters for the correct 'factors' is less confusing

I think it was done for convenience. Sometimes you want mega (10^6) for megawatts, but you almost never want to enter milli (10^-3), and you don't want to press Shift all the time for mega.

[veger]

Just giving my thoughts on the matter. I don't use either one of them as I let YAFC calculate all the needs, and I do not have 'end products' in either 'milli' or 'mega' range 😉

But from a standardization point of view: I like standards and YAFC does not implement them correctly, so it triggers me (a little).