-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fuel consumption recipe for products #109
Conversation
For some reason, I can't see the example image in your initial message. Have you put it into a message differently from pasting it with Ctrl+V? |
Did you mean |
Oops, i tried to copy the image from #76 (comment) and somehow messed up. Should work now.
Yes. |
For clarity, I advise to fix the |
I think that I also think that headers like |
One question, do we prefer to keep a linear commit history to see how we progressed and improved the code, or would a rebase that squashes it all minor changes together be preferable? |
Our goal is to make the commit history as understandable as possible. It means that ideally we want changes to be separated into logical steps of digestable size, without ad-hoc hotfixes or previous versions. However, I also understand how much effort and energy that can take. So I would say go for low-hanging fruits like squashing hotfixes, and separating formatting updates from logic changes. The rest is optional and depends on how good you want it to be. |
My typical commit history is an utter mess of small tries and fixes so i prefer to rebase a lot and squash related changes together. If only because that makes it so much easier for myself to review the changes and make later rebases so much smoother too. I'm also getting quite adept with the |
I see you're a man of culture as well. Props to a |
63bb50d
to
2e18174
Compare
perf: sort add fuel list once, not in display loop feat: prefer selected fuel
Decrease header size
Fixes #76
This adds the option for products that are usable as fuel, to select a recipe based on that fuel consumption. YaFC will then attempt to add said recipe using the selected fuel.
I had to do some performance optimization since the electric power, or biomass, tends to select most py recipes (!), i saw over 8000 of them in my debugger. It now pre-sorts the list when the popup is opened, not each time you move the mouse over.