Skip to content

Conversation

@zzzzBov
Copy link

@zzzzBov zzzzBov commented Apr 1, 2024

Fixes how metadata key-value pairs are split so that values can contain color characters.

Addresses #511

@qualityshepherd
Copy link

I'm only on my first cup of coffee... so apologies for my braindumb, but this is still not working for me. I see the updated regex in your file changes but when I build (npx grunt build), the dist/showdown.js gets updated with the old, broken code, and thus, my app still fails with colons in the metadata 🤔 Same if I try my app with package.json dependancies of "showdown": "https://github.com/zzzzBov/showdown/tree/fix-metadata-colons",.

Is dist not getting created properly? I mean, dist is checked in (which is odd)... so maybe it's getting overwritten?

@tivie tivie self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants