Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further updates to colorspace #38

Open
wants to merge 158 commits into
base: master
Choose a base branch
from
Open

further updates to colorspace #38

wants to merge 158 commits into from

Conversation

ssvfx41
Copy link

@ssvfx41 ssvfx41 commented Dec 18, 2019

No description provided.

daawaa and others added 30 commits September 10, 2018 14:36
Reverted Precomp/Element versioning
try function to catch the autocrop - DPX non option
updated for roto/cleanup linear EXRs
cleanup of fileset and colorspace
Cleanup of new Roto Version
Ocio dev - color_space section needs testsing across projects
latest ocio setup - ready for testing on projects
color space fix - test for global color settings
cleanup of color space settings
fixed project crop issue
fixed non-Version proj_reformat
# add to toolbar menu
cb_fn = lambda pn=profile_name: self.__write_node_handler.create_new_node(pn)
cb_fn = lambda pn=profile_name,wt=write_type: self.__write_node_handler.create_new_node(pn,wt)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not assign a lambda expression, use a def
missing whitespace after ','

for profile_name in self.__write_node_handler.profile_names:
write_type = "Version"
profile_list = []
write_node_icon = os.path.join(self.disk_location, "resources", "tk2_write.png").replace("\\","/")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace after ','

else:
nuke.tprint("Profile name not in list!")
profile_list = self.__write_node_handler.profile_names

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

@@ -153,7 +153,9 @@ def get_node_render_template(self, node):
"""
Return the render template for the specified node
"""
return self.__write_node_handler.get_render_template(node)
write_type = self.__write_node_handler.get_node_write_type_name(node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants