-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handler creates write under root #35
Open
j0yu
wants to merge
2
commits into
shotgunsoftware:master
Choose a base branch
from
wwfxuk:fix-incorrect-writenode-context
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix handler creates write under root #35
j0yu
wants to merge
2
commits into
shotgunsoftware:master
from
wwfxuk:fix-incorrect-writenode-context
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 10, 2019
houndci-bot
reviewed
May 13, 2019
Linted and good to review |
j0yu
force-pushed
the
fix-incorrect-writenode-context
branch
from
May 13, 2019 12:50
af495d8
to
70bab98
Compare
Liametc
approved these changes
May 13, 2019
j0yu
force-pushed
the
fix-incorrect-writenode-context
branch
2 times, most recently
from
August 11, 2021 11:04
272992a
to
e645c1e
Compare
j0yu
force-pushed
the
fix-incorrect-writenode-context
branch
from
August 11, 2021 11:31
e645c1e
to
b6e9e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue where the replacement write node is created inside the Shotgun Writenode (group) rather than at root.
New write nodes now created under the Nuke root context