Moves launching of RV to hook.#1
Open
tonybarbieri wants to merge 1 commit intoshotgunsoftware:masterfrom
Psyop:launch_rv_via_hook
Open
Moves launching of RV to hook.#1tonybarbieri wants to merge 1 commit intoshotgunsoftware:masterfrom Psyop:launch_rv_via_hook
tonybarbieri wants to merge 1 commit intoshotgunsoftware:masterfrom
Psyop:launch_rv_via_hook
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving this to a hook we are able to use our custom app launching api. Would the actual launching of RV occur with tk-multi-launchapp down the road? Could simplify things once launchapp is able to launch apps that may not have an engine. We already use the app_launch hook in launchapp to use our custom launching api.
thanks!
-tony