Skip to content

SG-21015 Add PR template #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SG-21015 Add PR template #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# tk-framework-desktopserver PR

## Description

Please write the purpose of this change

## Checklist before merging.

Please mark the checkbox if applicable.

- [ ] The Jira ticket number is on the PR title.
- [ ] Contains a change on the component's logic.
- [ ] Contains a change on unit tests.
- [ ] Requirements updates (CVEs, etc):
- **Main pull request**
- [ ] Only requirements.txt files are updated (no frozen ones).
- [ ] I've checked in Azure Pipelines that all Python versions and operating systems jobs executed without errors.
- [ ] I've opened a different PR for the `-automated` branch.
- **Automated pull request**
- [ ] This is the `-automated` branch generated by the main pull request.
- [ ] The main pull request is linked in the description.
- [ ] Fat binaries for apple silicon are not affected. [See README](resources/python/README.md#apple-silicon).
2 changes: 2 additions & 0 deletions resources/python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ git push
# Repeat steps for Python 3.9 and 3.10
```

##### Apple Silicon

> Important Notice for Apple Silicon: CI uses a Intel macOS to install the binary requirements.
> There are two specific ones that don't have wheels with fat binaries: CFFI and Zope.interface.
> For them, we recommend to get `_cffi_backend.cpython-310-darwin.so` and `_zope_interface_coptimizations.cpython-310-darwin.so`
Expand Down