Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant housenumbers in addresses layer #3

Open
yetzt opened this issue Jan 21, 2023 · 4 comments
Open

Redundant housenumbers in addresses layer #3

yetzt opened this issue Jan 21, 2023 · 4 comments

Comments

@yetzt
Copy link
Contributor

yetzt commented Jan 21, 2023

Many housenumbers appear multiple times, which appears to be an underlying problem with OSM data anchoing different POIs to the same building. Example: Nodes 769318431, 2423932912 and 2830792713 all point to the exactly same address with slightly different coordinates, and all are included in the layer with no means to only display one of them.

https://tools.geofabrik.de/map/#18/52.5022/13.4183&type=Geofabrik_Basic_Colour
https://tools.geofabrik.de/osmi/?view=addresses&lon=13.41938&lat=52.50150&zoom=19&baselayer=Geofabrik%20Standard&overlays=nodes_with_addresses_defined

@Nakaner
Copy link
Contributor

Nakaner commented Jan 23, 2023

This is caused by POIs having address tags and not considered bad practice in OSM. It is unnecessary if the building polygon has address tags but some mappers argue loudly in favour of it even if the building has address tags.

Unfortunately, Tilemaker allows almost no spatial queries. Therefore, merging close-by house numbers is not possible. We can add a boolean field from_poi to the addresses layer to indicate whether the feature comes from an OSM object which has any of the following keys: shop=*, amenity=*, leisure=*, tourism=*, man_made=*, disused:shop=*, disused:amenity=*, disused:leisure=*, disused:tourism=*, disused:man_made=*. This allows map style authors to render them with a lower priority.

@yetzt
Copy link
Contributor Author

yetzt commented Jan 23, 2023

Are there instances where housenumbers/housenames are only available in the POI? If not, i would propose that addresses attached to POIs should live in the pois layer only if thats feasible with tilemaker. Otherwise a from_poi hint would be appreciated.

@Nakaner
Copy link
Contributor

Nakaner commented Jan 23, 2023

Tilemaker can write an OSM object to one layer only. It is valid OSM tagging to map a building as a node only, especially if no high-res up to date aerial imagery is available. And even if buildings are mapped, we have to deal with addresses mapped as points (e.g. a building with different addresses per entrance).

@yetzt
Copy link
Contributor Author

yetzt commented Feb 26, 2023

one feasible way (as far as i understand the tilemaker documentation) might be to pull in the building relation and place the house number in the centroid, so at least housenumbers for the same building are placed over one aother and don't appear visibly duplicate? i'll investigate this if i find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants