Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate place names #1

Closed
cldellow opened this issue Jan 13, 2024 · 0 comments
Closed

duplicate place names #1

cldellow opened this issue Jan 13, 2024 · 0 comments

Comments

@cldellow
Copy link
Contributor

Even after handling label-nodes-in-relations for places, we have duplicates:

Selection_599

This is probably a data bug on the OSM side. For example, Mount Vernon:

The node is not linked to the relation :(

Ideas to fix:

  • fix the OSM data - this sounds interesting, but is a big task and would engage the OSM bot policies, so not an immediate solution
  • de-dupe in Tilemaker -- this would require a new feature in Tilemaker, to let some Lua code run on the per-tile output (it would also be useful for addressing Redundant housenumbers in addresses layer shortbread-tiles/shortbread-tilemaker#3, I think)
  • de-dupe in Lua -- maybe based on Wikidata ID, or name attribute?
    • simplest thing that could work: write a file with the wikidata ID, check its existence in relation phase
    • better would be a real database...but then we have a dependency on a real database. Maybe we could use SQLite if we sharded on ID?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant