Add review code #25
Open
Add review code #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xskrasek
reviewed
May 21, 2021
| from typing import Dict, List | ||
|
|
||
|
|
||
| def month_to_number(date: str) -> str: |
There was a problem hiding this comment.
There is not a check for None in date variable. There is however e.g. clean_date() function with the same parameter and it has a None check. It would be most likely better, if this was consistent.
xskrasek
reviewed
May 22, 2021
| return id, title, page | ||
|
|
||
|
|
||
| def postprocess_matches(matches: List[Tuple[str, str, str, str]]) \ |
There was a problem hiding this comment.
If you know, that you might pass None as an argument, you can use Optional[str], which should be equal to Union[str, None]. It seems, that you check for None in the code itself, but this will increase code clarity and that is really useful in bigger python codebases.
This is similiar to Variable? in e.g. newer C# versions.
Found using beartype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.