Skip to content

Fix: datepicker spacing #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

alastair-simon
Copy link
Contributor

What?

Fixes #587

Why?

The sizes and spacing between the datepicker and other form components should be aligned

How?

  • Fixed line-height
  • Added margin token
  • Added correct height token

@alastair-simon alastair-simon changed the title Fix/datepicker spacing Fix: datepicker spacing May 6, 2025
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 4:45pm

fabianhueske
fabianhueske previously approved these changes May 19, 2025
Copy link

pkg-pr-new bot commented May 19, 2025

Open in StackBlitz

@shopware-ag/meteor-admin-sdk

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@699

@shopware-ag/meteor-component-library

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@699

@shopware-ag/meteor-prettier-config

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-prettier-config@699

@shopware-ag/stylelint-plugin-meteor

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/stylelint-plugin-meteor@699

@shopware-ag/meteor-tokens

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@699

@shopware-ag/meteor-icon-kit

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@699

commit: 64d7e94

fabianhueske
fabianhueske previously approved these changes May 19, 2025
fix: remove unused gridArea styles

fix: input height

refactor: implement size prop

fix: hint spacing

remove unnessesary css comments

update snapshots

refactor: add margin consistent with other form components

fix: add deprecation warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Datepicker has different sizing and spacing regarding the rest of form controls
2 participants