refactor: remove setDefaultPaymentMethod from useUser and related tests #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mdanilowicz
requested review from
patzick,
mkucmus and
BrocksiNet
and removed request for
patzick
@shopware/api-client
@shopware/api-gen
@shopware/cms-base-layer
@shopware/composables
@shopware/helpers
@shopware/nuxt-module
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to remove the
setDefaultPaymentMethodmethod from theuseUsercomposable and the account payment method page from thevue-demo-store. The endpoint is no longer available on the backend side. The most important changes are listed below:Removal of
setDefaultPaymentMethodmethod:.changeset/ready-rice-grin.md: RemovedsetDefaultPaymentMethodmethod fromuseUsercomposable.packages/composables/src/useUser/useUser.ts: Removed thesetDefaultPaymentMethodmethod and its references from theuseUsercomposable. [1] [2] [3]packages/composables/src/useUser/useUser.test.ts: Removed the test case forsetDefaultPaymentMethodmethod.Removal of account payment method page:
.changeset/rude-windows-warn.md: Removed account payment method page fromvue-demo-store.templates/vue-demo-store/pages/account/payment.vue: Removed the account payment method page implementation.closes #1736
Type of change
ToDo's
Screenshots (if applicable)
Additional context