Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CmsBlockHtml and CmsElementHtml #1727

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

mdanilowicz
Copy link
Collaborator

Description

This pull request introduces a new component to render HTML blocks within the CMS base layer. The most important changes include the addition of the CmsBlockHtml component and its associated type definition.

New component addition:

Type definition:

closes #1528

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Feb 24, 2025 1:47pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Feb 24, 2025 1:47pm

Copy link

pkg-pr-new bot commented Feb 21, 2025

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1727

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1727

@shopware/cms-base-layer

npm i https://pkg.pr.new/shopware/frontends/@shopware/cms-base-layer@1727

@shopware/composables

npm i https://pkg.pr.new/shopware/frontends/@shopware/composables@1727

@shopware/nuxt-module

npm i https://pkg.pr.new/shopware/frontends/@shopware/nuxt-module@1727

@shopware/helpers

npm i https://pkg.pr.new/shopware/frontends/@shopware/helpers@1727

commit: 9d32a6e

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. block usually should contain slot elements, not render them
  2. what if there are more slots? Second is not rendered
  3. CmsElementText is rendering html in more advanced way, why not to use it?
  4. Missing example link to see results of this block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] HtmlCmsElement handling (CMS component)
2 participants