Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: build issue where mac catalyst target had AVCaptureSession extension redeclaration #1613

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

AppPear
Copy link
Contributor

@AppPear AppPear commented Oct 31, 2024

AVCaptureSession extension was redeclared if targetEnvironment(macCatalyst) was used

Description & motivation

Modified AVCaptureSession extension to separate targetEnvironment(macCatalyst) and rest of the extension

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)

@AppPear AppPear changed the title Fix: build issue where mac target had AVCaptureSession extesion redeclaration Fix: build issue where mac target had AVCaptureSession extension redeclaration Oct 31, 2024
@shogo4405
Copy link
Owner

how can i reproduce this issue?

@AppPear
Copy link
Contributor Author

AppPear commented Oct 31, 2024

just build the lib with mac catalyst target on mac os sequoia

@AppPear AppPear changed the title Fix: build issue where mac target had AVCaptureSession extension redeclaration Fix: build issue where mac catalyst target had AVCaptureSession extension redeclaration Oct 31, 2024
@AppPear
Copy link
Contributor Author

AppPear commented Oct 31, 2024

sorry the title was misleading mac catalyst target was problematic

@shogo4405
Copy link
Owner

ok. thank u.

@shogo4405 shogo4405 merged commit 4d19072 into shogo4405:main Oct 31, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants