Update audio track delegate on output format change #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogo4405
force-pushed
the
main
branch
2 times, most recently
from
6cf677a
to
5f95e3f
Compare
shogo4405
reviewed
Jun 30, 2024
| @@ -26,7 +26,7 @@ final class IOAudioMixerByMultiTrack: IOAudioMixerConvertible { | |||
| } | |||
| for id in tracks.keys { | |||
| buffers[id] = .init(outputFormat) | |||
| tracks[id] = .init(id: id, outputFormat: outputFormat) | |||
| tracks[id] = .init(id: id, outputFormat: outputFormat, delegate: self) | |||
There was a problem hiding this comment.
[IMO]
- I remember encountering a bug in some version of Swift where specifying a delegate in the constructor in a Release build would cause the weak reference to become nil. I thought it would be better to set the delegate in this line.
tracks[id]?.delegate = self
levs42
force-pushed
the
bugfix/track-delegate
branch
from
edf1565
to
0855e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR fixes an issue where audio tracks from multitrack mixer don't preserve their delegates. This leads to a state where AudioCodec doesn't receive current audio format from the mixer.
Type of change