fix validateDescription for firefox

shinyoshiaki · Dec 22, 2020 · ddcd650 · ddcd650
1 parent ca048b2
commit ddcd650
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 10 deletions.
diff --git a/examples/client-demo/src/containers/remote/media.tsx b/examples/client-demo/src/containers/remote/media.tsx
@@ -11,12 +11,13 @@ export const Media: FC<{ info: MediaInfo }> = ({ info }) => {
   useEffect(() => {
     client.events.onTrack.subscribe((stream, { mediaId }) => {
       if (mediaId !== info.mediaId) return;
-      stream.onremovetrack = () => {
-        setStream(undefined);
-      };
       videoRef.current.srcObject = stream;
       setStream(stream);
     });
+    client.events.onUnsubscribe.subscribe(({ mediaId }) => {
+      if (mediaId !== info.mediaId) return;
+      setStream(undefined);
+    });
   }, []);
 
   const changeQuality = (info: MediaInfo, type: SubscriberType) => {

diff --git a/packages/werift/rtc/peerConnection.ts b/packages/werift/rtc/peerConnection.ts
@@ -509,7 +509,10 @@ export class RTCPeerConnection {
     }
 
     description.media.forEach((media) => {
-      if (!media.iceParams.usernameFragment || !media.iceParams.password)
+      if (
+        media.direction !== "inactive" &&
+        (!media.iceParams.usernameFragment || !media.iceParams.password)
+      )
         throw new Error("ICE username fragment or password is missing");
     });
 

diff --git a/packages/werift/rtc/sdp.ts b/packages/werift/rtc/sdp.ts
@@ -36,11 +36,11 @@ export class SessionDescription {
 
   static parse(sdp: string) {
     const dtlsFingerprints: RTCDtlsFingerprint[] = [];
-    let dtlsRole = "";
-    let iceOptions = undefined;
-    let iceLite = false;
-    let icePassword = "";
-    let iceUsernameFragment = "";
+    let dtlsRole: string;
+    let iceOptions: string;
+    let iceLite: boolean = false;
+    let icePassword: string;
+    let iceUsernameFragment: string;
 
     const [sessionLines, mediaGroups] = groupLines(sdp);
 
@@ -495,7 +495,9 @@ export class GroupDescription {
 
 function ipAddressFromSdp(sdp: string) {
   const m = sdp.match(/^IN (IP4|IP6) ([^ ]+)$/);
-  if (!m) throw new Error("exception");
+  if (!m) {
+    throw new Error("exception");
+  }
   return m[2];
 }
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -0,0 +1,21 @@
+{
+  "compilerOptions": {
+    "target": "ES2020",
+    "module": "commonjs",
+    "lib": ["esnext", "ES2020"],
+    "declaration": true,
+    "outDir": "lib",
+    "strict": true,
+    "allowSyntheticDefaultImports": true,
+    "esModuleInterop": true,
+    "importHelpers": true,
+    "pretty": true,
+    "sourceMap": true,
+    "inlineSources": true,
+    "noUnusedLocals": false,
+    "skipLibCheck": true,
+    "strictNullChecks": false,
+    "noImplicitAny": false
+  },
+  "include": ["packages"]
+}