Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .claude-plugin/marketplace.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"name": "dev-workflows",
"source": "./dev-workflows",
"strict": true,
"version": "0.22.8",
"version": "0.22.9",
"description": "Skills + Subagents for backend development - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -82,7 +82,7 @@
"name": "dev-workflows-frontend",
"source": "./dev-workflows-frontend",
"strict": true,
"version": "0.22.8",
"version": "0.22.9",
"description": "Skills + Subagents for React/TypeScript - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -154,7 +154,7 @@
"name": "dev-workflows-fullstack",
"source": "./dev-workflows-fullstack",
"strict": true,
"version": "0.22.8",
"version": "0.22.9",
"description": "Skills + Subagents for fullstack development (backend + React/TypeScript) - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -243,7 +243,7 @@
"name": "dev-skills",
"source": "./dev-skills",
"strict": true,
"version": "0.22.8",
"version": "0.22.9",
"description": "Lightweight skills for users with existing workflows - coding best practices, testing principles, and design guidelines without recipe workflows or agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down
107 changes: 49 additions & 58 deletions agents/task-decomposer.md

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions agents/task-executor-frontend.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ Applies when Pre-implementation Verification finds a dependency this task requir

#### Adjacent Case Sweep (Required when the task file has a `Change Category` field set to one or more of `bug-fix`, `regression`, `state-change`, `boundary-change`)

Runs after Pre-implementation Verification, before the Binding Decision Check. This step fires on the field value the task decomposition wrote — read the field value and treat it as authoritative for whether the sweep applies.
Runs after Pre-implementation Verification, before the Binding Decision Check. This step fires on the field value the task materialization wrote — read the field value and treat it as authoritative for whether the sweep applies.

1. From the Investigation Targets (the decomposition already extended them with the adjacent files), identify the cases sharing the same path, contract, persisted state, or external boundary as the change — fallback rendering, stale state, retries, and external calls related to the change.
1. From the Investigation Targets (the materialization already extended them with the adjacent files), identify the cases sharing the same path, contract, persisted state, or external boundary as the change — fallback rendering, stale state, retries, and external calls related to the change.
2. Check the same defect class and record each case as `incorporated`, `unchanged` with evidence, or `out-of-scope` with the required scope decision; when none exist, record the searched surface.
3. Fold in-scope residuals into the applicable Proof Obligation and implementation; for `red-test`, include them in the failing tests.

Expand Down
4 changes: 2 additions & 2 deletions agents/task-executor.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,9 @@ Applies when Pre-implementation Verification finds a dependency this task requir

#### Adjacent Case Sweep (Required when the task file has a `Change Category` field set to one or more of `bug-fix`, `regression`, `state-change`, `boundary-change`)

Runs after Pre-implementation Verification, before the Binding Decision Check. This step fires on the field value the task decomposition wrote — read the field value and treat it as authoritative for whether the sweep applies.
Runs after Pre-implementation Verification, before the Binding Decision Check. This step fires on the field value the task materialization wrote — read the field value and treat it as authoritative for whether the sweep applies.

1. From the Investigation Targets (the decomposition already extended them with the adjacent files), identify the cases sharing the same path, contract, persisted state, or external boundary as the change — fallback behavior, stale state, retries, and external calls related to the change.
1. From the Investigation Targets (the materialization already extended them with the adjacent files), identify the cases sharing the same path, contract, persisted state, or external boundary as the change — fallback behavior, stale state, retries, and external calls related to the change.
2. Check the same defect class and record each case as `incorporated`, `unchanged` with evidence, or `out-of-scope` with the required scope decision; when none exist, record the searched surface.
3. Fold in-scope residuals into the applicable Proof Obligation and implementation; for `red-test`, include them in the failing tests.

Expand Down
28 changes: 14 additions & 14 deletions agents/work-planner.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ Choose Strategy A (TDD) if test skeletons are provided, Strategy B (implementati
- **Include a Proof Strategy in the work plan header** (see plan template) — name the proof source for each applicable verification mode and state that every task with a claim or verifiable deliverable records Proof Obligations for downstream review
- **Record the Review Scope in the work plan header** — for a fresh pre-implementation plan, the planned-files scope derived from the Design Doc and task target files; for a revision plan over existing work, the base branch and diff range — so the work plan review and downstream verification share one scope
- **Include a Failure Mode Checklist in the work plan** (see plan template) — enumerate all nine domain-independent failure categories (same-value, no-op, empty input, invalid option, missing config, unavailable boundary, shared-state dependency, rollback-only visibility, missing-sort-key ordering), mark which apply, and map each applicable one to its covering task(s), keeping entries free of project-specific names
- Include verification tasks in the phase corresponding to Verification Strategy's verification timing
- When test skeletons are provided, place integration test implementation in corresponding phases and E2E test execution in the final phase
- When test skeletons are not provided, include test implementation tasks based on Design Doc acceptance criteria
- Place verification work in the implementation task whose outcome it proves and in the phase required by Verification Strategy's timing
- When test skeletons are provided, include integration test implementation with the corresponding implementation outcome and E2E test execution in the final phase
- When test skeletons are not provided, include test implementation with the Design Doc acceptance criteria outcome it proves
- Final phase is always Quality Assurance

**E2E Gap Check (all strategies)**:
Expand Down Expand Up @@ -91,9 +91,9 @@ Read the Design Doc template from documentation-criteria skill to identify all s
| Category | What to Look For | Task Requirement |
|---|---|---|
| Implementation target | Components, functions, or data structures to create or modify | Implementation task |
| Connection/switching/registration | Integration points, dependency wiring, switching methods | Setup/wiring task |
| Contract change and propagation | Interface changes, data contract changes, field propagation across boundaries | Update task for each affected consumer |
| Verification requirement | Verification methods, test boundaries, integration verification points | Verification/test task |
| Connection/switching/registration | Integration points, dependency wiring, switching methods | Include in the implementation outcome it completes |
| Contract change and propagation | Interface changes, data contract changes, field propagation across boundaries | Keep affected consumers in the same contract-change outcome when rollback boundary and executor lane match; otherwise separate them |
| Verification requirement | Verification methods, test boundaries, integration verification points | Include in the implementation outcome it proves; use a dedicated task only for an independently consumable test artifact or setup outcome |
| Prerequisite work | Migration steps, security measures, environment setup | Prerequisite task |

Additionally, create Traceability rows for Design Convergence when it contains one or more Adopted Additions. For these other design-attention sections, create rows when the section is present and not N/A: State Transitions and Invariants, Field Propagation Map, Security Considerations, Logging and Monitoring sensitive-data rules, Error Handling matrix. Map each to the most relevant existing category (commonly `verification`, `contract-change`, or `prerequisite`).
Expand Down Expand Up @@ -158,7 +158,7 @@ For each referenced ADR:
Omit the table when no referenced ADR contains implementation-binding decisions.

### 6. Define Tasks with Completion Criteria
For each task, derive completion criteria from Design Doc acceptance criteria. Apply the 3-element completion definition (Implementation Complete, Quality Complete, Integration Complete).
For each task, derive completion criteria from Design Doc acceptance criteria and apply the 3-element completion definition (Implementation Complete, Quality Complete, Integration Complete). Populate the plan template's task-entry fields: stable `Phase X Task Y` ID, one Implementation outcome, concrete Target Files, one Rollback boundary, and one Executor lane (`backend` or `frontend`). Create separate task entries whenever the Implementation outcome, Rollback boundary, or Executor lane differs. Keep wiring or registration, tests, generated artifacts, and user documentation in the task whose outcome they complete or prove.

### 7. Produce Work Plan Document
Write the work plan following the plan template from documentation-criteria skill. Include Phase Structure Diagram and Task Dependency Diagram (mermaid).
Expand Down Expand Up @@ -189,7 +189,7 @@ Execute file output immediately (considered approved at execution).

## Important Task Design Principles

1. **Executable Granularity**: Each task as logical 1-commit unit, clear completion criteria, explicit dependencies
1. **Executable Granularity**: The plan template's task-entry format is the source of truth for single-commit boundaries.
2. **Built-in Quality**: Simultaneous test implementation, quality checks in each phase
3. **Risk Management**: List risks and countermeasures in advance, define detection methods
4. **Ensure Flexibility**: Prioritize essential purpose, include only information required for task execution and verification
Expand All @@ -201,7 +201,7 @@ Execute file output immediately (considered approved at execution).
2. **Quality Complete**: Tests, static checking, linting pass
3. **Integration Complete**: Coordination with other components verified

Include completion conditions in task names (e.g., "Service implementation and unit test creation")
Phrase each Implementation outcome as the condition completed by that task (e.g., "Service behavior implemented and verified by unit tests")

## Implementation Strategy Selection

Expand Down Expand Up @@ -280,14 +280,14 @@ Place all environment setup tasks in Phase 0 (before any implementation tasks).
**Test Classification**:
- Setup items (Mock preparation, measurement tools, Helpers, etc.) → Prioritize in Phase 1
- Unit tests (individual functions) → Use Red-Green-Refactor for new/changed behavior, or Baseline-Refactor-Verify for behavior-preserving refactors
- Integration tests → Place as create/execute tasks when relevant feature implementation is complete
- fixture-e2e tests → Place as create/execute tasks alongside the relevant UI feature implementation
- Integration tests → Include creation and execution in the relevant implementation outcome
- fixture-e2e tests → Include creation and execution in the relevant UI implementation outcome
- service-integration-e2e tests → Place as execute-only tasks in final phase
- Non-functional requirement tests (performance, UX, etc.) → Place in quality assurance phase
- Risk levels ("high risk", "required", etc.) → Move to earlier phases

**Task Generation Principles**:
- Always decompose 5+ test cases into subtasks (setup/high risk/normal/low risk)
- Group test cases with the implementation outcome they prove; use a separate task only for an independently consumable test artifact or setup outcome
- Specify "X test implementations" in each task (quantify progress)
- Specify traceability: Show correspondence with acceptance criteria in "AC1 support (3 items)" format

Expand All @@ -306,9 +306,9 @@ Decompose tasks based on implementation approach and technical dependencies deci

### Task Dependencies
- Dependencies up to 2 levels maximum (A→B→C acceptable, A→B→C→D requires redesign)
- Each task provides value independently as much as possible
- Use stable `Phase X Task Y` IDs from the task entries when declaring dependencies
- Clearly define dependencies and explicitly identify tasks that can run in parallel
- Include integration points in task names
- Include integration points in the Implementation outcome text

### Phase Composition
Compose phases based on technical dependencies and implementation approach from Design Doc.
Expand Down
2 changes: 1 addition & 1 deletion dev-skills/.claude-plugin/plugin.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "dev-skills",
"description": "Lightweight skills for users with existing workflows - coding best practices, testing principles, and design guidelines without recipe workflows or agents",
"version": "0.22.8",
"version": "0.22.9",
"author": {
"name": "Shinsuke Kagawa",
"url": "https://github.com/shinpr"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,15 @@ For a serialized boundary, fill Serialized Format and Consumer Parse Rule. Set t

Select ONE phase structure based on implementation approach from Design Doc. Phase Division Criteria are defined alongside this template. Per-phase quality checks run lint, typecheck, tests, build, and any adopted QA mechanisms from the Design Doc.

Each `Phase X Task Y` checkbox entry in a non-QA phase's `Tasks` section is one Work Plan implementation item. The ID is the stable key used by every `Covered By Task(s)` column.

- [ ] Phase X Task Y: [Observable behavior, contract, migration, or downstream-consumable deliverable completed by this item]
- **Target Files**: [Concrete planned paths or path prefixes]
- **Rollback boundary**: [Behavior, contract, migration, or persisted state reverted together]
- **Executor lane**: [backend | frontend]

Add one entry per implementation outcome. Create separate entries whenever the implementation outcome, rollback boundary, or executor lane differs. Select exactly one executor lane. Keep wiring or registration, tests, generated artifacts, and user documentation in the entry whose outcome they complete or prove. Record staged checks outside the `Tasks` section; they are phase checks rather than implementation items.

### Option A: Vertical Slice Phase Structure

Use when implementation approach is Vertical Slice. Each phase = one value unit with verification.
Expand All @@ -149,8 +158,12 @@ Use when implementation approach is Vertical Slice. Each phase = one value unit
**Verification**: [From Verification Strategy: early verification point]

#### Tasks
- [ ] Task 1: Implementation
- [ ] Task 2: Verification per Verification Strategy
- [ ] Phase 1 Task 1: [First value unit, including its wiring and verification]
- **Target Files**: [path(s)]
- **Rollback boundary**: [changes reverted together]
- **Executor lane**: [backend | frontend]

#### Phase Checks
- [ ] Quality check (staged)

#### Phase Completion Criteria
Expand All @@ -162,8 +175,12 @@ Use when implementation approach is Vertical Slice. Each phase = one value unit
**Verification**: [From Verification Strategy]

#### Tasks
- [ ] Task 1: Implementation
- [ ] Task 2: Verification per Verification Strategy
- [ ] Phase 2 Task 1: [Subsequent value unit, including its wiring and verification]
- **Target Files**: [path(s)]
- **Rollback boundary**: [changes reverted together]
- **Executor lane**: [backend | frontend]

#### Phase Checks
- [ ] Quality check

#### Phase Completion Criteria
Expand All @@ -178,44 +195,56 @@ Use when implementation approach is Horizontal Slice. Phases follow Foundation
**Purpose**: Contract definitions, interfaces, test preparation

#### Tasks
- [ ] Task 1: Specific work content
- [ ] Task 2: Specific work content
- [ ] Phase 1 Task 1: [Foundation outcome and its verification]
- **Target Files**: [path(s)]
- **Rollback boundary**: [changes reverted together]
- **Executor lane**: [backend | frontend]

#### Phase Checks
- [ ] Quality check (staged)
- [ ] Unit tests: All related tests pass

#### Phase Completion Criteria
- [ ] [Functional completion criteria]
- [ ] All related unit tests pass
- [ ] [Quality completion criteria]

### Phase 2: [Core Feature] (Estimated commits: X)
**Purpose**: Business logic, unit tests

#### Tasks
- [ ] Task 1: Specific work content
- [ ] Task 2: Specific work content
- [ ] Phase 2 Task 1: [Core feature outcome and its verification]
- **Target Files**: [path(s)]
- **Rollback boundary**: [changes reverted together]
- **Executor lane**: [backend | frontend]

#### Phase Checks
- [ ] Quality check (staged)
- [ ] Integration tests: Verify overall feature functionality

#### Phase Completion Criteria
- [ ] [Functional completion criteria]
- [ ] Integration tests verify overall feature functionality
- [ ] [Quality completion criteria]

### Phase 3: [Integration] (Estimated commits: X)
**Purpose**: External connections, presentation layer

#### Tasks
- [ ] Task 1: Specific work content
- [ ] Task 2: Specific work content
- [ ] Phase 3 Task 1: [Integration outcome and its verification]
- **Target Files**: [path(s)]
- **Rollback boundary**: [changes reverted together]
- **Executor lane**: [backend | frontend]

#### Phase Checks
- [ ] Quality check
- [ ] Integration tests: Verify component coordination

#### Phase Completion Criteria
- [ ] [Functional completion criteria]
- [ ] Integration tests verify component coordination
- [ ] [Quality completion criteria]

### Option C: Hybrid Phase Structure

Use when implementation approach is Hybrid. Combine vertical and horizontal phases as defined in Design Doc implementation approach. Structure phases per Design Doc specification, ensuring each phase has Tasks, Verification, and Phase Completion Criteria sections matching the format above.
Use when implementation approach is Hybrid. Combine vertical and horizontal phases as defined in Design Doc implementation approach. Use the same per-phase section structure as Option A/B.

### Final Phase: Quality Assurance (Required) (Estimated commits: 1)

Expand All @@ -229,7 +258,7 @@ This phase is required for ALL implementation approaches.
- [ ] Quality checks (types, lint, format)
- [ ] Execute all tests (including integration/E2E from test skeletons, when provided)
- [ ] Project-configured coverage threshold passes; when none is configured, review the coverage report and add tests for uncovered changed behavior or record why another verification method is sufficient
- [ ] Document updates
- [ ] Documentation updates required by implementation outcomes are complete

### Quality Assurance
- [ ] Quality check (staged)
Expand Down
Loading