Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

タグは最大40個までに制限する #732

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

shibafu528
Copy link
Member

refs #709

タグを無尽蔵に追加できたのを制限します。この制限はCSVインポートで一度に設定できるタグの数と同じです。

@shibafu528 shibafu528 changed the title タグは最大32個までに制限する タグは最大40個までに制限する Aug 5, 2021
@shibafu528
Copy link
Member Author

本番の最大タグ数が36個だったのを思い出し、譲歩することにしました

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #732 (f1560fb) into develop (f9fb0d2) will decrease coverage by 0.14%.
The diff coverage is 8.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #732      +/-   ##
=============================================
- Coverage      37.41%   37.26%   -0.15%     
- Complexity       773      779       +6     
=============================================
  Files             92       92              
  Lines           2558     2568      +10     
=============================================
  Hits             957      957              
- Misses          1601     1611      +10     
Impacted Files Coverage Δ
app/Http/Controllers/Api/WebhookController.php 97.82% <ø> (ø)
app/Http/Controllers/EjaculationController.php 0.00% <0.00%> (ø)
app/Services/CheckinCsvExporter.php 0.00% <0.00%> (ø)
app/Services/CheckinCsvImporter.php 91.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fb0d2...f1560fb. Read the comment docs.

@shibafu528 shibafu528 merged commit 925fa0d into develop Aug 11, 2021
@shibafu528 shibafu528 deleted the fix/709-validate-tags-qty branch August 11, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant