チェックイン時にメタデータからタグをサジェストする #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eai04191
reviewed
Jun 26, 2019
|
考え中 Loading
Failed
|
shibafu528
commented
Jun 27, 2019
| @Prop() readonly metadata!: Metadata | null; | ||
|
|
||
| // for use in v-if | ||
| private readonly MetadataLoadState = MetadataLoadState; |
There was a problem hiding this comment.
Vue的には変更しないのでcomputedのほうが良いのかなぁ
ただ、TSのClass styleで書くとこれより冗長になってしまう気がする
|
とりあえず現状コードで投入しちゃおうかなーと思ってます (悩みには結論が出なかったけど動いてるから一旦いっかの妥協) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
オカズリンクの入力後に自動でメタデータを取得し、MetadataResolverによってタグが提供されている場合は候補として表示するようにします。
Screenshot
refs #105