Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: transformer empty line fixtures #636

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

richardgill
Copy link
Contributor

Description

Shiki's focus and highlight transformers remove the <span> entirely if the comment line is otherwise empty.

This PR adds a fixture which tests this behavior.

Linked Issues

This behavior is discussed in #589

Additional context

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit e2f1ea0
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/65fea7131cd42b0008ebe8b1
😎 Deploy Preview https://deploy-preview-636--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit e2f1ea0
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/65fea713764fe80008757b56
😎 Deploy Preview https://deploy-preview-636--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@richardgill richardgill force-pushed the transformer-empty-line-fixtures branch from f05241d to e2f1ea0 Compare March 23, 2024 09:55
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (be74312) to head (e2f1ea0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          70       70           
  Lines        5699     5699           
  Branches      755      756    +1     
=======================================
  Hits         5489     5489           
  Misses        205      205           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu antfu changed the title Test: transformer empty line fixtures test: transformer empty line fixtures Mar 23, 2024
@antfu antfu merged commit ec2bffa into shikijs:main Mar 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants