-
Notifications
You must be signed in to change notification settings - Fork 14
Add job audit script #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job audit script #222
Conversation
23ee673 to
605a1c9
Compare
stephenfin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get a blurb in the README for this new script? Could of additional points inline.
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also see the frequency at which the periodics run?
| from pathlib import Path | ||
|
|
||
| import yaml | ||
| from ruamel.yaml import YAML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
humm, why do we need 2 yaml libraries? Can't we use PyYAML for writing the report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the PyYAML output was less readable, so switched to ruamel to make the output more readable but PyYAML is still required for parsing. I can switch back to only PyYAML but I prefer the output with ruamel.
Add job audit script to create a yaml showcasing conditions for the job to run from config
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eshulman2, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add job audit script to create a yaml showcasing conditions for the job to run from config