Skip to content

Conversation

@eshulman2
Copy link
Contributor

Add job audit script to create a yaml showcasing conditions for the job to run from config

@openshift-ci openshift-ci bot requested review from mandre and stephenfin December 10, 2025 15:19
@eshulman2 eshulman2 force-pushed the main branch 2 times, most recently from 23ee673 to 605a1c9 Compare December 14, 2025 10:10
@eshulman2 eshulman2 requested a review from stephenfin December 14, 2025 10:13
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a blurb in the README for this new script? Could of additional points inline.

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also see the frequency at which the periodics run?

from pathlib import Path

import yaml
from ruamel.yaml import YAML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm, why do we need 2 yaml libraries? Can't we use PyYAML for writing the report?

Copy link
Contributor Author

@eshulman2 eshulman2 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PyYAML output was less readable, so switched to ruamel to make the output more readable but PyYAML is still required for parsing. I can switch back to only PyYAML but I prefer the output with ruamel.

Add job audit script to create a yaml showcasing conditions for the job to run from config
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eshulman2, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 945dec9 into shiftstack:main Jan 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants