Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be, I believe the changes that needed to be made to follow the discussion here;
SAP/ui5-webcomponents#9487
The hope is that it would still as before in vite, but allow the option to use a CDN if desired. i.e. to allow loading out of a CDN, bypassing the need for a bundler. As far as I can tell at the moment, this seems to work in a large % of cases.
However, apparently not with internationalisation at the moment, which is critical for
DatePicker
components for example.I see errors like this; when loading that page
Unhandled Promise Rejection: Error: CLDR data for locale en_GB is not loaded!
Which is not encouraging. At this stage unclear if;
Arg...