fix(sites): Remediate false positive for Spotify #2701
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
- Changed errorType from 'status_code' to 'message' - Added errorMsg check for 'Page not found' - Updated username_claimed to 'spotify' (verified working) Spotify returns HTTP 200 for both valid and invalid users, then shows 'Page not found' in the HTML for non-existent profiles. The previous status_code check caused false positives. Tested with: - Non-existent user: Correctly returns NOT FOUND - Real user 'spotify': Correctly returns FOUND - Verified against username_claimed Fixes: sherlock-project#2547
JDeep1234
force-pushed
the
fix/spotify-false-positive
branch
from
25ea5a9 to
ba361dc
Compare
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false positive issue for Spotify username detection reported in Issue #2547.
Problem: Spotify was using status_code detection which caused false positives for non-existent usernames.
Solution: Changed detection method from status_code to message-based detection to properly identify Page not found responses for non-existent users.
Changes:
Testing: Verified with 3 test scenarios - all passing:
Fixes #2547