Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --chrome-launch option #41

Merged
merged 2 commits into from
Oct 15, 2019
Merged

feat: add --chrome-launch option #41

merged 2 commits into from
Oct 15, 2019

Conversation

gamtiq
Copy link
Contributor

@gamtiq gamtiq commented Oct 8, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

Please Describe Your Changes

I've added an option to have ability passing additional settings to chrome-launcher.
Probably it will help to bypass problems like #32.

@shellscape
Copy link
Owner

Thanks for putting this together. I'll have a look later today.

@shellscape shellscape merged commit 096e05e into shellscape:master Oct 15, 2019
@shellscape
Copy link
Owner

Thanks for the PR. Please note that I've renamed the flag to --chrome-launcher. It will be released on a minor later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants