Permit basic authentication in metrics endpoint (kube-burner#584)

## Type of change - [ ] Refactor - [x] New feature - [ ] Bug fix - [ ] Optimization - [x] Documentation Update ## Description Permit basic authentication for metrics endpoint ## Related Tickets & Documents - Related Issue # - Closes # Signed-off-by: Raul Sevilla <[email protected]>
shashank-boyapally · Jan 25, 2024 · 0a8b0d5 · 0a8b0d5
1 parent 207304d
commit 0a8b0d5
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/docs/cli.md b/docs/cli.md
@@ -79,7 +79,8 @@ A metrics-endpoints.yaml file with valid keys for the `init` command would look
   profile: metrics.yaml
   alertProfile: alert-profile.yaml
 - endpoint: http://remotehost:9090
-  token: <token>
+  username: foo
+  password: bar
 ```
 
 !!! Note

diff --git a/pkg/prometheus/types.go b/pkg/prometheus/types.go
@@ -63,6 +63,8 @@ type MetricEndpoint struct {
 	Token        string `yaml:"token"`
 	Profile      string `yaml:"profile"`
 	AlertProfile string `yaml:"alertProfile"`
+	Username     string `yaml:"username"`
+	Password     string `yaml:"password"`
 }
 
 type metric struct {

diff --git a/pkg/util/metrics/metrics.go b/pkg/util/metrics/metrics.go
@@ -60,13 +60,15 @@ func ProcessMetricsScraperConfig(metricsScraperConfig ScraperConfig) Scraper {
 				Token:        metricsScraperConfig.Token,
 				Profile:      metricsScraperConfig.MetricsProfile,
 				AlertProfile: metricsScraperConfig.AlertProfile,
+				Username:     metricsScraperConfig.Username,
+				Password:     metricsScraperConfig.Password,
 			})
 		}
 	}
 	for _, metricsEndpoint := range metricsEndpoints {
 		auth := prometheus.Auth{
-			Username:      metricsScraperConfig.Username,
-			Password:      metricsScraperConfig.Password,
+			Username:      metricsEndpoint.Username,
+			Password:      metricsEndpoint.Password,
 			Token:         metricsEndpoint.Token,
 			SkipTLSVerify: metricsScraperConfig.SkipTLSVerify,
 		}

diff --git a/pkg/workloads/helpers.go b/pkg/workloads/helpers.go
@@ -120,6 +120,8 @@ func (wh *WorkloadHelper) Run(workload string, metricsProfiles []string, alertsP
 				auth := prometheus.Auth{
 					Token:         metricsEndpoint.Token,
 					SkipTLSVerify: true,
+					Username:      metricsEndpoint.Username,
+					Password:      metricsEndpoint.Password,
 				}
 				p, err := prometheus.NewPrometheusClient(ConfigSpec, metricsEndpoint.Endpoint, auth, stepSize, wh.MetricsMetadata, indexer, embedConfig)
 				if err != nil {