fixed error detection & reporting on wineprefix creation failure #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! That's a good addition! |
sharkwouter
requested changes
Oct 3, 2023
LeXofLeviafan
force-pushed
the
fix-wineprefix-error-detection
branch
from
b31797d
to
b8f950a
Compare
|
Thanks! Sorry about forgetting about this for a while. I had some stuff going on in my personal life. The contribution is really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the prefix creation failure is ignored, and consequently leads to an error at a later step (typically a generic "unhandled error" message).
Adding a check and showing contextual error message (as well as logging the error) makes it easier to figure out what went wrong (…e.g. that the
wineexecutable is not in current$PATH😅).