inline format arguments #3217
Merged
inline format arguments #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you provide benchmarking to demonstrate the difference please? thanks! |
|
closing as won't fix (but let's reopen if benchmarks can demonstrate a difference) |
|
@Enselic my appologies, take a look at rust-lang/rust-clippy#10851 |
|
P.S. See also rust bug itself rust-lang/rust#112156 |
|
thanks! let's get this merged then there is a lint for this and it would be nice to activate it in bat CI to avoid regressions, but that doesn't block merging this |
|
can you resolve conflicts and rebase please? |
Enselic
added
the
waiting-on-author
In a few cases, removed the unneeded `&` - this causes a minor slowdown because compiler cannot eliminate those (yet).
|
thx, rebased |
|
P.S. Sadly, there is no lint yet - that's why i created rust-lang/rust-clippy#10851 |
Enselic
removed
the
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few cases, removed the unneeded
&- this causes a minor slowdown because compiler cannot eliminate those (yet).