Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Chinese Documentation #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Chinese Documentation #400

wants to merge 1 commit into from

Conversation

Rain120
Copy link

@Rain120 Rain120 commented Oct 30, 2020

Feature

  • Chinese Documentation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.359% when pulling f3ff9ac on Rain120:master into 346eb0c on share:master.

@alecgibson
Copy link
Collaborator

Hi! Thanks so much for this! We're looking into hopefully tidying up the README soon, so let's put this on hold for now. We'll give you another ping when we've updated it, if that's okay?

@Rain120
Copy link
Author

Rain120 commented Nov 5, 2020

@alecgibson

Thx for your reply. That's ok after you are updated on the file about README.

curran
curran approved these changes Jan 1, 2021
View reviewed changes
Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seems harmless to merge now, even if the README will be reorganized in future.

@Rain120
Copy link
Author

Rain120 commented Jan 2, 2021

Wooow, Nice job ☺️

@curran
Copy link
Contributor

curran commented Aug 22, 2021

I'm curious, where is the Chinese documentation defined? Is it in a separate repository?

@Rain120
Copy link
Author

Rain120 commented Aug 25, 2021

Yes, I am afraid of effect this repo, so I just do it in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curran curran curran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rain120 @coveralls @alecgibson @curran