-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #13 from share/linter
👷 Add linting
- Loading branch information
Showing
4 changed files
with
57 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// The ESLint ecmaVersion argument is inconsistently used. Some rules will ignore it entirely, so if the rule has | ||
// been set, it will still error even if it's not applicable to that version number. Since Google sets these | ||
// rules, we have to turn them off ourselves. | ||
var DISABLED_ES6_OPTIONS = { | ||
'no-var': 'off', | ||
'prefer-rest-params': 'off' | ||
}; | ||
|
||
var SHAREDB_RULES = { | ||
// Comma dangle is not supported in ES3 | ||
'comma-dangle': ['error', 'never'], | ||
// We control our own objects and prototypes, so no need for this check | ||
'guard-for-in': 'off', | ||
// Google prescribes different indents for different cases. Let's just use 2 spaces everywhere. Note that we have | ||
// to override ESLint's default of 0 indents for this. | ||
indent: ['error', 2, { | ||
SwitchCase: 1 | ||
}], | ||
// Less aggressive line length than Google, which is especially useful when we have a lot of callbacks in our code | ||
'max-len': ['error', | ||
{ | ||
code: 120, | ||
tabWidth: 2, | ||
ignoreUrls: true | ||
} | ||
], | ||
// Google overrides the default ESLint behaviour here, which is slightly better for catching erroneously unused | ||
// variables | ||
'no-unused-vars': ['error', {vars: 'all', args: 'after-used'}], | ||
// It's more readable to ensure we only have one statement per line | ||
'max-statements-per-line': ['error', {max: 1}], | ||
// ES3 doesn't support spread | ||
'prefer-spread': 'off', | ||
// as-needed quote props are easier to write | ||
'quote-props': ['error', 'as-needed'], | ||
'require-jsdoc': 'off', | ||
'valid-jsdoc': 'off' | ||
}; | ||
|
||
module.exports = { | ||
extends: 'google', | ||
parserOptions: { | ||
ecmaVersion: 3 | ||
}, | ||
rules: Object.assign( | ||
{}, | ||
DISABLED_ES6_OPTIONS, | ||
SHAREDB_RULES | ||
) | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
var RedisPubSub = require('../index'); | ||
var redisPubSub = require('../index'); | ||
|
||
require('sharedb/test/pubsub')(function(callback) { | ||
callback(null, RedisPubSub()); | ||
callback(null, redisPubSub()); | ||
}); |