Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 gem explicitly as dependency #263

Closed
wants to merge 1 commit into from

Conversation

mataku
Copy link
Contributor

@mataku mataku commented Jun 8, 2024

Summary

closes #256

base64 is no longer the default gem from Ruby 3.4
https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/

On Ruby 3.3, we could see the warning:

warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

From Ruby 3.4, we will get the error:

Failure/Error: require 'base64'

LoadError:
  cannot load such file -- base64

Added

Add base64 dependency to gemspec

base64 is no longer the default gem from Ruby 3.4
@mataku mataku force-pushed the feature/fix-bundled-gem-warning branch from d84346b to 1e7594e Compare June 24, 2024 03:56
@mataku
Copy link
Contributor Author

mataku commented Oct 2, 2024

@swarley please review and let me know if you have any questions

@PixeLInc
Copy link
Member

This fix was included in another PR that was merged: #277

so going to close this one out. Thanks for the PR, though.

@PixeLInc PixeLInc closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 3.3 deprecation warnings: base64 will no longer be part of the default gems
2 participants