Fix/function naming and comments errors #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat : add signature authorization for node signers chore : remove commented out code chore : refactoring the authorization code feat: implement transaction ID generation and validation in receipt processing chore : modify verifyAppliedReceiptSignatures & archiverReceiptData feat: improve signature authorization & verification for receipts chore : fix failing archiver unit tests
fix : comment out calls for OriginalTxData feat: update schemaTx to couple receipt validation with OriginalTxData
moved logic of txid verification to verifyNonGlobalTxReceipt method for non-global txs save originalTxsData in storeReceiptData flow fix: use txId from trusted fields in receipts nodePubkey length validation and lowercase to allow case insensitive comparison fix: unique signers for signature verification fix: voteHash calculation and some logs fix: executionShardKey ajv validation + remove gossip of original txs data
…network formation
Author
|
Hi devs! @aniketdivekar @urnotsam @kun6fup4nd4 Resolved all the conflicts and ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.