Address Todos #142
Merged
Address Todos #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Covered two more TODOs with the latest commits. |
JosefWN
reviewed
Oct 31, 2022
|
@shamblett Did you maybe have the chance to have a look on this PR and #141 yet? |
|
OK, they look OK to me, I'll merge them if you agree. |
Sure, that would be great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the TODOs mentioned in #140 and a couple of minor linting issues.
As part of this PR, the
isPrintablemethod is removed from theCoapMediaTypeenum as it did not fulfill a real purpose IMHO.