Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address TODO comments across the code base #140

Open
shamblett opened this issue Oct 29, 2022 · 0 comments
Open

Address TODO comments across the code base #140

shamblett opened this issue Oct 29, 2022 · 0 comments

Comments

@shamblett
Copy link
Owner

There are a a few TODO comments building up across the code base, see below, these need to be either fixed or removed if no longer needed.

Found 17 TODO items in 6 files

coap_link_format.dart
(22, 6) // TODO(JKRhb): Revisit typing
(63, 6) // TODO(JKRhb): This needs to be a value between 1 and 4294967295.

integer_option.dart
(27, 8) // TODO(JKRhb): The handling of endianness should be revisited here.
(46, 8) // TODO(JKRhb): The handling of endianness should be revisited here.
(190, 4) // TODO(JKRhb): Is this really a class U option?
(228, 4) // TODO(JKRhb): Is this really a class E option?
(238, 4) // TODO(JKRhb): Is this really a class E option?

oscore_option.dart
(8, 4) // TODO(JKRhb): This currently can only contain encoded values and does not
(22, 6) // TODO(JKRhb): Maybe this can be done more elegantly

coap_client.dart
(40, 4) // FIXME: The name MatchETags might be a bit misleading, c.f. https://datatracker.ietf.org/doc/html/rfc7252#section-5.10.8.2

coap_media_type.dart
(336, 6) // TODO(JKRhb): Are there any uncovered cases?

coap_message.dart
(107, 10) // TODO(JKRhb): Revisit conditions for rejection
(238, 6) // TODO(JKRhb): Should rejections be included here as well?
(430, 6) // TODO(JKRhb): Apply proper percent-encoding
(469, 6) // TODO(JKRhb): Apply proper percent-encoding
(512, 6) // TODO(JKRhb): Apply proper percent-encoding
(560, 6) // TODO(JKRhb): Apply proper percent-encoding

@shamblett shamblett mentioned this issue Oct 29, 2022
11 tasks
@JKRhb JKRhb mentioned this issue Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant