fix: support pnpm v9 lockfiles #472
Conversation
WalkthroughThe update enriches Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Note that CI is currently failing due to #470 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional Context Used
LanguageTool (78)
CHANGELOG.md (78)
Near line 1: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: * For the changelog of versions prior to v6, see the [5.x stable branch of rails...
Near line 4: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...grading to new spelling in version 7. * Please see the [v6 Upgrade Guide](./docs/v6_up...
Near line 4: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...docs/v6_upgrade.md) to go from versions prior to v6. * [ShakaCode](https://www.shakacode...
Near line 5: Unpaired symbol: ‘[’ seems to be missing
Context: ... from versions prior to v6. * ShakaCode offers suppo...
Near line 17: Unpaired symbol: ‘[’ seems to be missing
Context: ...s://github.com/g-rath). ## [v8.0.0.rc.2] - May 7, 2024 ### Breaking changes - R...
Near line 39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...G-Rath. - Removehttpsoption forwebpack-dev-server...
Near line 41: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...G-Rath. - Removeverify_file_existancemethod [PR 446]...
Near line 49: Possible missing comma found.
Context: ...additional_pathswill have their path stripped just like with thesource_path. [PR 4...
Near line 58: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...ad of errors when compilation is success but stderr is not empty. [PR 416](https://g...
Near line 61: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...G-Rath](https://github.com/g-rath) ### Removed - Removes dependency ongloblibrary. [PR 435](...
Near line 67: Possible missing article found.
Context: ...viously this could have been ignored in few code branches, especially when checking...
Near line 74: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tagliala). ## [v7.2.1] - December 30, 2023 ### Fixed - Show d...
Near line 79: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/ahangarha). ## [v7.2.0] - December 28, 2023 ### Added - Experi...
Near line 104: Unpaired symbol: ‘[’ seems to be missing
Context: ...acode/shakapacker/pull/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed comman...
Near line 104: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...acker/pull/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed commands execution fo...
Near line 105: Possible typo: you repeated a word
Context: ...l/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed commands execution for projects with sp...
Near line 108: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/kukicola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creati...
Near line 108: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...b.com/kukicola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creation of assets:pr...
Near line 109: Possible typo: you repeated a word
Context: ...icola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creation of assets:precompile if it is ...
Near line 112: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/ahangarha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the c...
Near line 112: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/ahangarha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the condition for sho...
Near line 113: Possible typo: you repeated a word
Context: ...arha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the condition for showing warning for s...
Near line 116: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/ahangarha). ## [v7.0.0] - June 23, 2023 ### Breaking changes - ...
Near line 116: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/ahangarha). ## [v7.0.0] - June 23, 2023 ### Breaking changes - Removes defaults...
Near line 120: Possible missing article found.
Context: ...s. This has been removed and returns to sensible default of the preset which is to figur...
Near line 120: Possible missing comma found.
Context: ... and returns to sensible default of the preset which is to figure out the file type fr...
Near line 120: Possible missing comma found.
Context: ...is change might affect generated output however so it is marked as breaking. - Export ...
Near line 144: ‘Prior to’ might be wordy. Consider a shorter alternative.
Context: ...dracz](https://github.com/tomdracz). Prior to this change, top level directory of sta...
Near line 144: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...com/tomdracz). Prior to this change, top level directory of static assets like images ...
Near line 146: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...tic/image.jpg")`. Going forward, the top level directory of static files will be retai...
Near line 146: Use a comma before ‘so’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...rectory of static files will be retained so this will necessitate the update of fil...
Near line 153: Possible missing article found.
Context: ...s. This has been removed and returns to sensible default of the preset which is to figur...
Near line 153: Possible missing comma found.
Context: ... and returns to sensible default of the preset which is to figure out the file type fr...
Near line 153: Possible missing comma found.
Context: ...is change might affect generated output however so it is marked as breaking. - Fixed R...
Near line 157: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...arha](https://github.com/ahangarha) ### Removed - Remove redundant enhancement for precompile ta...
Near line 161: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/ahangarha). ## [v6.6.0] - March 7, 2023 ### Improved - Allow configuration of w...
Near line 165: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...alecslupu). ## [v6.5.6] - February 11, 2023 ### Fixed - Fixed failing to update `bi...
Near line 166: Possible typo: you repeated a word
Context: ...). ## [v6.5.6] - February 11, 2023 ### Fixed - Fixed failing to updatebin/setupfile due ...
Near line 184: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tagliala). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed re...
Near line 184: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...m/tagliala). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed regression caused by ...
Near line 185: Possible typo: you repeated a word
Context: ...a). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed regression caused by 6.5.3. PR #192 int...
Near line 188: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/Eric-Guo). ## [v6.5.3] - November 1, 2022 ### Improved - Set ...
Near line 195: Unpaired symbol: ‘[’ seems to be missing
Context: ...acode/shakapacker/pull/192). ## [v6.5.2] - September 8, 2022 ### Upgrade Remove...
Near line 207: Unpaired symbol: ‘[’ seems to be missing
Context: ...duction" : "development" ``` ## [v6.5.1] - August 15, 2022 ### Improved - Resol...
Near line 218: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/pulkitkkr). ## [v6.5.0] - July 4, 2022 ### Added - `append_styl...
Near line 218: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ....com/pulkitkkr). ## [v6.5.0] - July 4, 2022 ### Added - `append_stylesheet_pack_tag...
Near line 225: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...ub.com/artemave) ## [v6.4.1] - June 5, 2022 ### Fixed - Restores automatic installa...
Near line 233: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tomdracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue...
Near line 233: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...b.com/tomdracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue 123: Rails 7.0...
Near line 234: Possible typo: you repeated a word
Context: ...dracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue 123: Rails 7.0.3 - Webpacker con...
Near line 238: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...se nested entries. This was the default prior to v6.0. Because entries maybe generated, ...
Near line 243: Unpaired symbol: ‘[’ seems to be missing
Context: ... assets:precompile task enhancement #131](https://github.com/shakacode/shakapacke...
Near line 243: Possible missing comma found.
Context: ...lled before asset precompilation. Going forward you will need to ensure these packages ...
Near line 243: If this is a question, use a question mark.
Context: ...tasks/yarn.rake) in your own application. ## [v6.3.0] - May 19, 2022 ### Improv...
Near line 245: Unpaired symbol: ‘[’ seems to be missing
Context: ...ke) in your own application. ## [v6.3.0] - May 19, 2022 ### Improved - Add abil...
Near line 251: Possible missing comma found.
Context: ...//github.com/tomdracz). ### Fixed - On Windows CSS urls no longer contain backslashes ...
Near line 260: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...e mode can affect how your code runs in a variety of ways, but in newer versions of Babel it...
Near line 264: You’ve repeated a verb. Did you mean to only write one of them?
Context: ... change probably won't affect you. ### Added - Addswebpacker_precompilesetting to `webp...
Near line 271: The modal verb ‘will’ requires the verb’s base form.
Context: ...timestamp will be checked together will timestamps of all files and directories inside of ...
Near line 273: Possible missing comma found.
Context: ... in improved compiler checks performance but might be breaking for certain setups an...
Near line 278: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tomdracz). ## [v6.2.1] - April 15, 2022 ### Fixed - Put back c...
Near line 278: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/tomdracz). ## [v6.2.1] - April 15, 2022 ### Fixed - Put back config.public_mani...
Near line 282: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/justin808). ## [v6.2.0] - March 22, 2022 ### Added - Make mani...
Near line 292: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...ple invocations of stylesheet_pack_tag (eg for a regular stylesheet & a print styl...
Near line 295: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/dleavitt). ## [v6.1.1] - February 6, 2022 ### Added - Support...
Near line 300: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tomdracz). ## [v6.1.0] - February 4, 2022 ### Added - Support ...
Near line 300: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...m/tomdracz). ## [v6.1.0] - February 4, 2022 ### Added - Support for SWC loader. [PR...
Near line 307: Unpaired symbol: ‘[’ seems to be missing
Context: .../rails/webpacker/pull/2802). ## [v6.0.2] - January 25, 2022 ### Improved - Fix i...
Near line 307: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: .../pull/2802). ## [v6.0.2] - January 25, 2022 ### Improved - Fix incorrect command na...
Near line 311: Unpaired symbol: ‘[’ seems to be missing
Context: ...ps://github.com/tricknotes). ## [v6.0.1] - January 24, 2022 ### Improved - PR #2...
Near line 311: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...tricknotes). ## [v6.0.1] - January 24, 2022 ### Improved - PR #21 removed pnp-webpa...
Near line 315: Unpaired symbol: ‘[’ seems to be missing
Context: ...k). ## [v6.0.0 changes from v6.0.0.rc.6] - January 22, 2022 ### Improved - Rais...
Near line 325: Unpaired symbol: ‘]’ seems to be missing
Context: ... Make watched_files_digest thread safe. [rails/webpacker #3233](https://github.co...
Near line 326: Unpaired symbol: ‘]’ seems to be missing
Context: ...ingle webpack config webpack.config.js. [rails/webpacker #3240](https://github.co...
Near line 344: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...renvironment.js, this must be removed or you will receive an error (`Item nodeMo...
Near line 347: Unpaired symbol: ‘]’ seems to be missing
Context: ...'` per recommendation in the Babel docs [#2709](https://github.com/rails/webpacke...
Near line 348: Possible missing comma found.
Context: ...09) - Adds experimental Yarn 2 support. Note you must manually set `nodeLinker: node...
Near line 349: Unpaired symbol: ‘]’ seems to be missing
Context: ....yarnrc.yml`. - Fixes dev server issues [#2898](https://github.com/rails/webpacke...
Additional comments not posted (1)
CHANGELOG.md (1)
15-15: Ensure the CHANGELOG entry for PR 472 is clear and concise.The entry succinctly captures the essence of the changes made for supporting PNPM v9 lockfiles. It's linked properly to the PR and the contributor, which is good for traceability.
|
Tests broken. Should we fix first? |
|
@G-Rath please rebase on main. |
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
CHANGELOG.md (1)
15-15: Ensure the CHANGELOG entry for PR 472 is clear and detailed.Consider expanding the description to include a brief summary of what changes were made to support PNPM v9 lockfiles, as this will provide more context for the users.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- CHANGELOG.md (1 hunks)
- lib/shakapacker/version_checker.rb (1 hunks)
- spec/fixtures/relative_path_pnpm-lock.v9.yaml (1 hunks)
- spec/fixtures/without_pnpm-lock.v9.yaml (1 hunks)
- spec/shakapacker/version_checker_spec.rb (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- lib/shakapacker/version_checker.rb
- spec/fixtures/relative_path_pnpm-lock.v9.yaml
- spec/fixtures/without_pnpm-lock.v9.yaml
- spec/shakapacker/version_checker_spec.rb
Additional Context Used
LanguageTool (77)
CHANGELOG.md (77)
Near line 1: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: * For the changelog of versions prior to v6, see the [5.x stable branch of rails...
Near line 4: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...grading to new spelling in version 7. * Please see the [v6 Upgrade Guide](./docs/v6_up...
Near line 4: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...docs/v6_upgrade.md) to go from versions prior to v6. * [ShakaCode](https://www.shakacode...
Near line 5: Unpaired symbol: ‘[’ seems to be missing
Context: ... from versions prior to v6. * ShakaCode offers suppo...
Near line 17: Unpaired symbol: ‘[’ seems to be missing
Context: ...s://github.com/g-rath). ## [v8.0.0.rc.2] - May 7, 2024 ### Breaking changes - R...
Near line 39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...G-Rath. - Removehttpsoption forwebpack-dev-server...
Near line 41: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...G-Rath. - Removeverify_file_existancemethod [PR 446]...
Near line 49: Possible missing comma found.
Context: ...additional_pathswill have their path stripped just like with thesource_path. [PR 4...
Near line 58: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...ad of errors when compilation is success but stderr is not empty. [PR 416](https://g...
Near line 61: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...G-Rath](https://github.com/g-rath) ### Removed - Removes dependency ongloblibrary. [PR 435](...
Near line 67: Possible missing article found.
Context: ...viously this could have been ignored in few code branches, especially when checking...
Near line 74: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tagliala). ## [v7.2.1] - December 30, 2023 ### Fixed - Show d...
Near line 79: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/ahangarha). ## [v7.2.0] - December 28, 2023 ### Added - Experi...
Near line 104: Unpaired symbol: ‘[’ seems to be missing
Context: ...acode/shakapacker/pull/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed comman...
Near line 104: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...acker/pull/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed commands execution fo...
Near line 105: Possible typo: you repeated a word
Context: ...l/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed commands execution for projects with sp...
Near line 108: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/kukicola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creati...
Near line 108: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...b.com/kukicola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creation of assets:pr...
Near line 109: Possible typo: you repeated a word
Context: ...icola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creation of assets:precompile if it is ...
Near line 112: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/ahangarha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the c...
Near line 112: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/ahangarha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the condition for sho...
Near line 113: Possible typo: you repeated a word
Context: ...arha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the condition for showing warning for s...
Near line 116: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/ahangarha). ## [v7.0.0] - June 23, 2023 ### Breaking changes - ...
Near line 116: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/ahangarha). ## [v7.0.0] - June 23, 2023 ### Breaking changes - Removes defaults...
Near line 120: Possible missing comma found.
Context: ...ery file in the codebase was treated as TSX leading to potential issues. This has b...
Near line 120: Possible missing article found.
Context: ...s. This has been removed and returns to sensible default of the preset which is to figur...
Near line 120: Possible missing comma found.
Context: ... and returns to sensible default of the preset which is to figure out the file type fr...
Near line 144: ‘Prior to’ might be wordy. Consider a shorter alternative.
Context: ...dracz](https://github.com/tomdracz). Prior to this change, top level directory of sta...
Near line 144: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...com/tomdracz). Prior to this change, top level directory of static assets like images ...
Near line 146: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...tic/image.jpg")`. Going forward, the top level directory of static files will be retai...
Near line 146: Use a comma before ‘so’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...rectory of static files will be retained so this will necessitate the update of fil...
Near line 153: Possible missing comma found.
Context: ...ery file in the codebase was treated as TSX leading to potential issues. This has b...
Near line 153: Possible missing article found.
Context: ...s. This has been removed and returns to sensible default of the preset which is to figur...
Near line 153: Possible missing comma found.
Context: ... and returns to sensible default of the preset which is to figure out the file type fr...
Near line 157: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...arha](https://github.com/ahangarha) ### Removed - Remove redundant enhancement for precompile ta...
Near line 161: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/ahangarha). ## [v6.6.0] - March 7, 2023 ### Improved - Allow configuration of w...
Near line 165: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...alecslupu). ## [v6.5.6] - February 11, 2023 ### Fixed - Fixed failing to update `bi...
Near line 166: Possible typo: you repeated a word
Context: ...). ## [v6.5.6] - February 11, 2023 ### Fixed - Fixed failing to updatebin/setupfile due ...
Near line 184: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tagliala). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed re...
Near line 184: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...m/tagliala). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed regression caused by ...
Near line 185: Possible typo: you repeated a word
Context: ...a). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed regression caused by 6.5.3. PR #192 int...
Near line 188: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/Eric-Guo). ## [v6.5.3] - November 1, 2022 ### Improved - Set ...
Near line 195: Unpaired symbol: ‘[’ seems to be missing
Context: ...acode/shakapacker/pull/192). ## [v6.5.2] - September 8, 2022 ### Upgrade Remove...
Near line 207: Unpaired symbol: ‘[’ seems to be missing
Context: ...duction" : "development" ``` ## [v6.5.1] - August 15, 2022 ### Improved - Resol...
Near line 218: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/pulkitkkr). ## [v6.5.0] - July 4, 2022 ### Added - `append_styl...
Near line 218: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ....com/pulkitkkr). ## [v6.5.0] - July 4, 2022 ### Added - `append_stylesheet_pack_tag...
Near line 225: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...ub.com/artemave) ## [v6.4.1] - June 5, 2022 ### Fixed - Restores automatic installa...
Near line 233: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tomdracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue...
Near line 233: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...b.com/tomdracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue 123: Rails 7.0...
Near line 234: Possible typo: you repeated a word
Context: ...dracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue 123: Rails 7.0.3 - Webpacker con...
Near line 238: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...se nested entries. This was the default prior to v6.0. Because entries maybe generated, ...
Near line 243: Unpaired symbol: ‘[’ seems to be missing
Context: ... assets:precompile task enhancement #131](https://github.com/shakacode/shakapacke...
Near line 243: Possible missing comma found.
Context: ...urself. Should you wish to restore this behaviour you'll need to [reimplement the task](h...
Near line 243: If this is a question, use a question mark.
Context: ...tasks/yarn.rake) in your own application. ## [v6.3.0] - May 19, 2022 ### Improv...
Near line 245: Unpaired symbol: ‘[’ seems to be missing
Context: ...ke) in your own application. ## [v6.3.0] - May 19, 2022 ### Improved - Add abil...
Near line 251: Possible missing comma found.
Context: ...//github.com/tomdracz). ### Fixed - On Windows CSS urls no longer contain backslashes ...
Near line 260: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...e mode can affect how your code runs in a variety of ways, but in newer versions of Babel it...
Near line 264: You’ve repeated a verb. Did you mean to only write one of them?
Context: ... change probably won't affect you. ### Added - Addswebpacker_precompilesetting to `webp...
Near line 271: The modal verb ‘will’ requires the verb’s base form.
Context: ...timestamp will be checked together will timestamps of all files and directories inside of ...
Near line 278: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tomdracz). ## [v6.2.1] - April 15, 2022 ### Fixed - Put back c...
Near line 278: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...com/tomdracz). ## [v6.2.1] - April 15, 2022 ### Fixed - Put back config.public_mani...
Near line 282: Unpaired symbol: ‘[’ seems to be missing
Context: ...tps://github.com/justin808). ## [v6.2.0] - March 22, 2022 ### Added - Make mani...
Near line 292: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...ple invocations of stylesheet_pack_tag (eg for a regular stylesheet & a print styl...
Near line 295: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/dleavitt). ## [v6.1.1] - February 6, 2022 ### Added - Support...
Near line 300: Unpaired symbol: ‘[’ seems to be missing
Context: ...ttps://github.com/tomdracz). ## [v6.1.0] - February 4, 2022 ### Added - Support ...
Near line 300: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...m/tomdracz). ## [v6.1.0] - February 4, 2022 ### Added - Support for SWC loader. [PR...
Near line 307: Unpaired symbol: ‘[’ seems to be missing
Context: .../rails/webpacker/pull/2802). ## [v6.0.2] - January 25, 2022 ### Improved - Fix i...
Near line 307: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: .../pull/2802). ## [v6.0.2] - January 25, 2022 ### Improved - Fix incorrect command na...
Near line 311: Unpaired symbol: ‘[’ seems to be missing
Context: ...ps://github.com/tricknotes). ## [v6.0.1] - January 24, 2022 ### Improved - PR #2...
Near line 311: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ...tricknotes). ## [v6.0.1] - January 24, 2022 ### Improved - PR #21 removed pnp-webpa...
Near line 315: Unpaired symbol: ‘[’ seems to be missing
Context: ...k). ## [v6.0.0 changes from v6.0.0.rc.6] - January 22, 2022 ### Improved - Rais...
Near line 325: Unpaired symbol: ‘]’ seems to be missing
Context: ... Make watched_files_digest thread safe. [rails/webpacker #3233](https://github.co...
Near line 326: Unpaired symbol: ‘]’ seems to be missing
Context: ...ingle webpack config webpack.config.js. [rails/webpacker #3240](https://github.co...
Near line 344: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...renvironment.js, this must be removed or you will receive an error (`Item nodeMo...
Near line 345: The preposition ‘to’ seems more likely in this position.
Context: ...iningCss. This is useful to enable HMR for React. - Webpacker's wrapper to thesp...
Near line 347: Unpaired symbol: ‘]’ seems to be missing
Context: ...'` per recommendation in the Babel docs [#2709](https://github.com/rails/webpacke...
Near line 349: Unpaired symbol: ‘]’ seems to be missing
Context: ....yarnrc.yml`. - Fixes dev server issues [#2898](https://github.com/rails/webpacke...
|
@justin808 done |
Summary
This was introduced with PNPN v9 and requires a couple of minor changes to support.
Pull Request checklist
Update documentationOther Information
Prior art around this: google/osv-scanner#934
Summary by CodeRabbit
New Features
Documentation
Tests
node_package_versionmethod for comprehensive testing.