Fix CI failure #1593
Merged
Fix CI failure #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahangarha tests still not fixed |
Yes. This is a draft and is still in WIP state. |
ahangarha
force-pushed
the
fix-ci-failure-for-sqlite-installation
branch
2 times, most recently
from
2dd6081
to
5f81dd5
Compare
ahangarha
force-pushed
the
fix-ci-failure-for-sqlite-installation
branch
from
5f81dd5
to
97ea030
Compare
ahangarha
force-pushed
the
fix-ci-failure-for-sqlite-installation
branch
from
5cf4bde
to
baaf259
Compare
ahangarha
changed the title
Judahmeek
approved these changes
Jan 7, 2024
justin808
reviewed
Jan 8, 2024
| @@ -3,7 +3,9 @@ | |||
| gem "shakapacker", "7.0.1" | |||
| gem "bootsnap", require: false | |||
| gem "rails", "~> 7.0", ">= 7.0.1" | |||
| gem "sqlite3" | |||
|
|
|||
| # sqlite3 1.7.0 ends native gem support for Ruby 2.7 | |||
There was a problem hiding this comment.
Needed for dummy app test
I tried to move it to the gemfile of the dummy app but it didn't work. So I kept it here and just fixed the version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key notes:
sqlite3to be below1.7.0since the native gem support for Ruby 2.7 ended in this version.headless=newoption. More information: Headless is Going Away!This change is