Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lodash and update dependencies #147

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Add lodash and update dependencies #147

merged 1 commit into from
Nov 5, 2015

Conversation

josiasds
Copy link
Member

@josiasds josiasds commented Nov 3, 2015

Add lodash as discussed in #124.

@@ -1,3 +1,5 @@
import _find from 'lodash/collection/find';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the lodash docs, loading only the required method is "great for smaller builds with browserify/webpack". I kept the _ in the method name just for consistency with the library.

@justin808
Copy link
Member

LGTM

justin808 added a commit that referenced this pull request Nov 5, 2015
Add lodash and update dependencies
@justin808 justin808 merged commit f3d3d98 into master Nov 5, 2015
@robwise robwise deleted the add-lodash branch November 6, 2015 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants