Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ gem "jbuilder"
gem "mini_racer", "~> 0.21.4"

# The library which provides react helpers and more in rails
gem "react_on_rails", "17.0.0.rc.6"
gem "react_on_rails", "17.0.0.rc.9"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion (non-blocking): this jumps three release candidates (rc.6 → rc.9) in one step. Since react_on_rails is still pre-1.0 and RC APIs can shift between candidates, it'd be worth a quick skim of the upstream CHANGELOG for rc.7–rc.9 to confirm there are no relevant breaking changes beyond what's already been validated here (doctor/tests/build all green per the PR description).


# Modern javscript compressor
gem "terser"
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ GEM
prism (>= 1.6.0)
rbs (>= 4.0.0)
tsort
react_on_rails (17.0.0.rc.6)
react_on_rails (17.0.0.rc.9)
addressable
connection_pool
execjs (~> 2.5)
Expand Down Expand Up @@ -314,7 +314,7 @@ DEPENDENCIES
pry-remote
puma (~> 8.0)
rails (~> 8.1.3)
react_on_rails (= 17.0.0.rc.6)
react_on_rails (= 17.0.0.rc.9)
selenium-webdriver
shakapacker (= 10.2.0)
sprockets-rails
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"react": "19.2.7",
"react-dom": "19.2.7",
"react-jazzicon": "^1.0.4",
"react-on-rails": "17.0.0-rc.6",
"react-on-rails": "17.0.0-rc.9",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Vendored Server Runtime May Lag

The npm package is upgraded to 17.0.0-rc.9, but the repository’s server entry still imports a vendored react-server.js file that was not changed in this PR. If that vendored runtime was generated from the older RC and RC9 expects a different server-rendering protocol, any prerender: true page can fail during SSR or render with mismatched client/server behavior.

"react_ujs": "^3.3.1",
"sass-loader": "^17.0.0",
"shakapacker": "10.2.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2961,10 +2961,10 @@ react-jazzicon@^1.0.4:
dependencies:
mersenne-twister "^1.1.0"

react-on-rails@17.0.0-rc.6:
version "17.0.0-rc.6"
resolved "https://registry.npmjs.org/react-on-rails/-/react-on-rails-17.0.0-rc.6.tgz#4372994d13e7dcff4acaf06efad7b413da4bc42d"
integrity sha512-/u2hzYvuUN+1HnH0gEdbfQvkWkgLMSN2kl/2x9CCOInIHffBvilgXzBgJrP5NlvjWpguUWSxO6PrYpgV0BzLMA==
react-on-rails@17.0.0-rc.9:
version "17.0.0-rc.9"
resolved "https://registry.npmjs.org/react-on-rails/-/react-on-rails-17.0.0-rc.9.tgz#b6a3af1bee13bbebffb94c94e1fda3080f1b2b0c"
integrity sha512-gg3FqUo/pJYLL2uwb+jZbrE8JfBGDVO1cuqhfxePVnYA1lJyh3kTK+4Kd5eO+JHYpMFLYqU4axbu+GYbCqLXug==

react-refresh@0.18.0:
version "0.18.0"
Expand Down