Skip to content

Commit

Permalink
ci: Fix workflow events (#38)
Browse files Browse the repository at this point in the history
This was found by auditing workflows based on research published here:

https://github.com/joeyparrish/workflow-cheat-sheet

The research was prompted by a workflow bug in Shaka Streamer
  • Loading branch information
joeyparrish authored Nov 6, 2024
1 parent b981687 commit 3007f32
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,28 @@ jobs:

# The logic below handles npm publication. Each step is conditional on a
# release having been created by someone merging the release PR.
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
ref: refs/tags/${{ steps.release.outputs.tag_name }}
if: ${{ steps.release.outputs.release_created }}

- uses: actions/setup-node@v1
with:
node-version: 12
registry-url: 'https://registry.npmjs.org'
if: ${{ steps.release.outputs.release_created }}

- run: npm ci
if: ${{ steps.release.outputs.release_created }}

- run: npm publish
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
if: ${{ steps.release.outputs.release_created }}

- run: npm pack
if: ${{ steps.release.outputs.release_created }}

- uses: svenstaro/upload-release-action@483c1e56f95e88835747b1c7c60581215016cbf2
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
13 changes: 12 additions & 1 deletion .github/workflows/test-gha.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ on:
required: false
default: false

concurrency:
group: ${{ github.workflow }}-${{ github.event.number || inputs.ref }}
cancel-in-progress: true

name: Test in GitHub Actions Environment

jobs:
Expand All @@ -21,13 +25,19 @@ jobs:

runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
ref: ${{ github.ref }}

- uses: actions/setup-node@v1
with:
node-version: 12
registry-url: 'https://registry.npmjs.org'

- run: npm ci

- run: node ./main.js

- name: Check installed drivers
shell: bash
run: |
Expand All @@ -53,5 +63,6 @@ jobs:
check_driver msedgedriver.exe || rv=1
fi
exit "$rv"
- uses: mxschmitt/action-tmate@v3
if: ${{ failure() && github.event_name == 'workflow_dispatch' && github.event.inputs.debug_enabled }}

0 comments on commit 3007f32

Please sign in to comment.