-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Migrate Firefox from macos-13 to macos-latest #6853
Conversation
Incremental code coverage: No instrumented code was changed. |
It seems like there is not much point in migrating Firefox without migrating Chrome and Edge, since the build times for macos-13 Chrome and Edge will still dominate the overall test time. And we can't move those without solving #6508 |
@joeyparrish Taking into account the number of executions there are, saving 3 minutes in each execution is a lot! even if it's just Firefox |
I'm not sure what you mean. Are you saying that if we have to do a rerun, and that rerun doesn't include Chrome-Mac and Edge-Mac, we save 3 minutes on the rerun? |
In my tests we have a limited number of macos runners, so if we save time in this case, if there are many jobs in the queue, we can speed up the queue because this type of job lasts 3 minutes less. I don't find any problem in not merging this. |
Ah, I see. I'll expand the description with this information, then approve and merge. |
Using arm (macos-latest) wherever possible reduces build times by 3 minutes. We have a limited number of macos runners, so if we save time even on Firefox alone (all we can do pending #6508), we can speed up the queue of pending jobs across PRs.
Using arm (macos-latest) wherever possible reduces build times by 3 minutes. We have a limited number of macos runners, so if we save time even on Firefox alone (all we can do pending #6508), we can speed up the queue of pending jobs across PRs.
Using arm (macos-latest) wherever possible reduces build times by 3 minutes.
We have a limited number of macos runners, so if we save time even on Firefox alone (all we can do pending #6508), we can speed up the queue of pending jobs across PRs.