Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix incomplete 3.4.1 release #1471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joeyparrish
Copy link
Member

google-github-actions/release-please-action has been deprecated and replaced with googleapis/release-please-action.

@joeyparrish
Copy link
Member Author

The 3.4.1 release didn't work correctly, and it's not clear why. The later jobs that are supposed to trigger off of a release were skipped. The outputs don't seem to be any different between the old action and the new one, but I'm hoping this fixes it anyway. I will try to test this further on my fork to make sure this resolves the problem before I merge it.

@joeyparrish joeyparrish requested a review from cosmin January 9, 2025 19:56
@joeyparrish
Copy link
Member Author

The linter workflow is broken by an upgrade to Python 3.12 in GitHub Actions. Fix for that in #1472

@joeyparrish
Copy link
Member Author

This appears to be effective. Here's a release workflow behaving correctly on my fork: https://github.com/joeyparrish/shaka-packager/actions/runs/12698664742

@joeyparrish joeyparrish changed the title ci: Update release-please-action fix(ci): Fix incomplete 3.4.1 release Jan 9, 2025
@joeyparrish
Copy link
Member Author

Renamed this PR to "fix(ci)" so that it triggers a new release (3.4.2) to replace the broken release (3.4.1).

google-github-actions/release-please-action has been deprecated and replaced with googleapis/release-please-action.
@joeyparrish
Copy link
Member Author

Rebased on top of #1472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant