Support -key-file flag #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing keys/passwords in command line is not very good from security standpoint. One could examine password in runner script/process list/etc. So I propose to add an option flag to load base64-encoded key from file. It's also more convenient when running shadowsocks in Kubernetes where one usually mounts secrets as files.
marshall-lee
force-pushed
the
flag-password-file
branch
from
2ce92a4
to
3574380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing keys/passwords in command line is not very good from security standpoint. One could examine password in runner script/process list/etc.
So I propose to add an option flag to load base64-encoded key from file.
It's also more convenient when running shadowsocks in Kubernetes where one usually mounts secrets as files.