Skip to content

fix(route): extract pattern with Uri instance - #7

Draft
shadowhand wants to merge 1 commit into
mainfrom
fix/skip-uri-string
Draft

shadowhand wants to merge 1 commit into
mainfrom
fix/skip-uri-string

Conversation

@shadowhand

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

🏹 Robin

✅ Review done. I flagged 2 things worth a look.

Push fixes whenever you like, then comment /robin for another pass.

Robin v2.10.2 · antongulin/robin@main (58947b3) · diff-only review (agent mode off)

@shadowhand
shadowhand marked this pull request as draft October 10, 2026 10:45

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏹 Robin

Heads up: this is a point-in-time review. Push fixes freely, then comment /robin whenever you want another pass.

⚠️ 1 Medium | 🔵 1 Low

Summary

The diff simplifies the match method by renaming variables and inlining the URI retrieval. The variable rename is clean and harmless. However, the key change replaces a cast-to-string (string) $request->getUri() with a direct $request->getUri() call, changing the argument type from string to UriInterface. This could break if the pattern's extract method expects a string, and it also moves the getUri() call inside the loop, slightly increasing redundant calls.


Robin — the Robin Hood of code review. Free for every PR.

Comment thread src/RouteList.php
Comment thread src/RouteList.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant