Revert "etc/login.defs: enable CREATE_HOME" #1181
Open
+477
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dcb6b0f.
|
I suspect this is not a big deal, and most distributions just ship their own version verbatim like debian/login.defs. But if there is a distro - or even a person - using this as is from upstream, then we dont' want to break them. So let's undo this and use an etc/login.defs.test for the testing if needed. |
I suspect this is not a big deal, and most distributions just ship their own version verbatim like debian/login.defs. But if there is a distro - or even a person - using this as is from upstream, then we dont' want to break them. So let's undo this and use an etc/login.defs.test for the testing if needed. Signed-off-by: Serge Hallyn <[email protected]>
Comment on lines
+1
to
+5
| # | ||
| # /etc/login.defs - Configuration control definitions for the shadow package. | ||
| # | ||
| # $Id$ | ||
| # |
There was a problem hiding this comment.
Maybe we should have a tests/etc/ subdirectory? I'm not very happy mixing actual stuff and tests.
|
For commit 1: Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit dcb6b0f.