Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/, src/: Use streq() instead of its pattern #1136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Dec 2, 2024


Revisions:

v1b
  • Rebase
$ git range-diff master..gh/streq shadow/master..streq
1:  224930f8 = 1:  c122513c lib/chkname.c: is_valid_name(): Use streq() instead of its pattern
v1c
  • Rebase
$ git range-diff master..gh/streq shadow/master..streq
1:  c122513c = 1:  7a8f1e66 lib/chkname.c: is_valid_name(): Use streq() instead of its pattern
v1d
  • Rebase
$ git range-diff master..gh/streq shadow/master..streq
1:  7a8f1e66 = 1:  d335844d lib/chkname.c: is_valid_name(): Use streq() instead of its pattern
v1e
  • Rebase
$ git range-diff master..gh/streq shadow/master..streq 
1:  d335844d ! 1:  4aee5e06 lib/chkname.c: is_valid_name(): Use streq() instead of its pattern
    @@ Commit message
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/chkname.c ##
    -@@
    - #include <sys/param.h>
    - #include <unistd.h>
    - 
    --#include "defines.h"
    - #include "chkname.h"
    -+#include "defines.h"
    -+#include "string/strcmp/streq.h"
    - 
    - 
    - int allow_bad_names = false;
     @@ lib/chkname.c: is_valid_name(const char *name)
               */
        int numeric;
v2
  • Use !streq() instead of its pattern
$ git range-diff master gh/streq streq 
1:  4aee5e06 = 1:  4aee5e06 lib/chkname.c: is_valid_name(): Use streq() instead of its pattern
-:  -------- > 2:  dda02b8b src/useradd.c: create_home(): Use !streq() instead of its pattern
v2b
  • Rebase
$ git range-diff alx/master..gh/streq master..streq 
1:  4aee5e06 = 1:  6c440b9f lib/chkname.c: is_valid_name(): Use streq() instead of its pattern
2:  dda02b8b = 2:  a1bde477 src/useradd.c: create_home(): Use !streq() instead of its pattern

@alejandro-colomar alejandro-colomar added the Simpler A good issue for a new beginner label Dec 2, 2024
@alejandro-colomar alejandro-colomar force-pushed the streq branch 3 times, most recently from 7a8f1e6 to d335844 Compare December 6, 2024 12:10
@alejandro-colomar
Copy link
Collaborator Author

Queued after the release of 4.17.0.

@alejandro-colomar alejandro-colomar marked this pull request as draft December 6, 2024 12:15
@alejandro-colomar alejandro-colomar changed the title lib/chkname.c: is_valid_name(): Use streq() instead of its pattern lib/, src/: Use streq() instead of its pattern Dec 10, 2024
@alejandro-colomar alejandro-colomar marked this pull request as ready for review December 22, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simpler A good issue for a new beginner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant