st*spn()-related improvements #1126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
changed the title
alejandro-colomar
force-pushed
the
strrcspn
branch
from
265afe0 to
c23e3e2
Compare
alejandro-colomar
changed the title
alejandro-colomar
force-pushed
the
strrcspn
branch
4 times, most recently
from
c9514aa to
ed8f24e
Compare
alejandro-colomar
force-pushed
the
strrcspn
branch
from
ed8f24e to
293297a
Compare
These APIs are to strrspn(), like strcspn() is to strspn(). They are like strcspn(3), but search from the end of the string. The function is meant for internal use, and consistency with libc. The macro is meant for normal use, since it returns a pointer, which is what algorithms using this need. See also strspn(3) and strcspn(3). Signed-off-by: Alejandro Colomar <[email protected]>
This provides a better organization. Signed-off-by: Alejandro Colomar <[email protected]>
… function and macro This provides a safer and more consistent API. We had the strrspn(3) function as it was for compatibility with Oracle Solaris, but let's not repeat their mistake. Nevertheless, name our function strrspn_() with a trailing underscore, to differentiate it from the one in Solaris, since it's slightly different. Signed-off-by: Alejandro Colomar <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
alejandro-colomar
force-pushed
the
strrcspn
branch
from
293297a to
3c73ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queued after the release of 4.17.0.
Revisions:
v1b