fix(docs): remove redundant check icon from combobox example#9251
Open
PhilemonChiro wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(docs): remove redundant check icon from combobox example#9251PhilemonChiro wants to merge 1 commit intoshadcn-ui:mainfrom
PhilemonChiro wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
The combobox example was showing a manual Check icon, but the CommandItem component already has a built-in check icon that responds to the data-checked attribute. This caused duplicate check icons when users installed components via CLI. Updated the example to use data-checked attribute instead of manually rendering a Check icon. Fixes shadcn-ui#9225
Contributor
|
@PhilemonChiro is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Check>icon from combobox example sinceCommandItemhas a built-in check icondata-checkedattribute to control the check icon visibilitycnimport from example codeProblem
When users install the Command component via CLI, the
CommandItemincludes a built-in check icon controlled bydata-checked. However, the combobox documentation example manually renders a<Check>icon, causing duplicate check marks to appear.This was reported in #9225.
Solution
Updated the combobox example to use the
data-checkedattribute onCommandIteminstead of manually rendering a<Check>icon. This aligns with how other blocks (like github.tsx) handle selection state.Test plan
http://localhost:4000/docs/components/comboboxFixes #9225