feat: Support remote registry urls in cli #4992
Open
+62
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillionverma is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
dillionverma
commented
Sep 27, 2024
| @@ -439,7 +466,7 @@ function getRegistryUrl(path: string) { | |||
| return url.toString() | |||
| } | |||
|
|
|||
| return `${REGISTRY_URL}/${path}` | |||
There was a problem hiding this comment.
hard-coded dependency on registry url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a proof of concept to enable the following command
Would allow users to browse remote registries using the cli and select multiple components at a time
This removes the hardcoded dependency on
REGISTRY_URL: